From 44384a90c754e859af6d687ed154754fba15b03d Mon Sep 17 00:00:00 2001 From: Codex Date: Thu, 28 May 2026 10:23:59 +0000 Subject: [PATCH] Use default Codex approval reviewer Stop forcing approvalsReviewer=user on thread and turn start so reviewer routing follows Codex app-server defaults, matching CLI behavior. --- internal/codexapp/client.go | 16 +++++++--------- internal/codexapp/client_test.go | 4 ++-- 2 files changed, 9 insertions(+), 11 deletions(-) diff --git a/internal/codexapp/client.go b/internal/codexapp/client.go index 3d15bdc..2cd5df7 100644 --- a/internal/codexapp/client.go +++ b/internal/codexapp/client.go @@ -248,11 +248,10 @@ func (c *Client) StartThread(ctx context.Context, cwd, model, sandbox string) (T return Thread{}, err } params := map[string]any{ - "cwd": cwd, - "approvalPolicy": "on-request", - "approvalsReviewer": "user", - "sandbox": threadSandbox(sandbox), - "serviceName": "codex_telegram_bot", + "cwd": cwd, + "approvalPolicy": "on-request", + "sandbox": threadSandbox(sandbox), + "serviceName": "codex_telegram_bot", } if model != "" { params["model"] = model @@ -336,10 +335,9 @@ func (c *Client) StartTurn(ctx context.Context, threadID, cwd, model, reasoningE return Turn{}, err } params := map[string]any{ - "threadId": threadID, - "input": input, - "approvalPolicy": "on-request", - "approvalsReviewer": "user", + "threadId": threadID, + "input": input, + "approvalPolicy": "on-request", } if strings.TrimSpace(cwd) != "" { params["cwd"] = cwd diff --git a/internal/codexapp/client_test.go b/internal/codexapp/client_test.go index 5886590..45cf642 100644 --- a/internal/codexapp/client_test.go +++ b/internal/codexapp/client_test.go @@ -78,7 +78,7 @@ func TestClientWebSocketUnixJSONRPC(t *testing.T) { return } startParams := start["params"].(map[string]any) - if startParams["approvalsReviewer"] != "user" || startParams["approvalPolicy"] != "on-request" { + if _, ok := startParams["approvalsReviewer"]; ok || startParams["approvalPolicy"] != "on-request" { payload, _ := json.Marshal(startParams) serverDone <- unexpectedMessage("thread/start approval params", string(payload)) return @@ -104,7 +104,7 @@ func TestClientWebSocketUnixJSONRPC(t *testing.T) { return } turnParams := turnStart["params"].(map[string]any) - if turnParams["approvalsReviewer"] != "user" || turnParams["approvalPolicy"] != "on-request" { + if _, ok := turnParams["approvalsReviewer"]; ok || turnParams["approvalPolicy"] != "on-request" { payload, _ := json.Marshal(turnParams) serverDone <- unexpectedMessage("turn/start approval params", string(payload)) return