cabbage/rvbox
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: fence token fallback before launch preparation

Browse Source
This commit is contained in:
cabbage
2026-09-06 14:08:01 +00:00
parent f5794e0017
commit 3f08950415
1 changed files with 11 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/client/agent/executor.go
+11 -8
View File
@@ -114,14 +114,12 @@ func (executor *Executor) launch(ctx context.Context, issue domain.UUID, revisio
if workingDirectory == "" { if workingDirectory == "" {
workingDirectory = executor.WorkDir workingDirectory = executor.WorkDir
} }
if err := executor.Store.SetLaunchPhase(ctx, issue, domain.LaunchPhasePrepared, "", 0); err != nil { // The supervisor resolves all token fallback and creates/assigns the child
return err // while it is still suspended. Only after that immutable identity exists do
} // we persist launch_prepared; therefore no context fallback can occur after
// The native Windows supervisor creates/assigns the Job while the child is // the durable preparation barrier. A daemon crash before this write leaves
// suspended. It does not cross the durable authorization barrier until the // no authorized launch, and the kill-on-close Job prevents a suspended child
// process object has been fully prepared and its immutable identity is // from surviving restart.
// available. A daemon crash before this write leaves only launch_prepared;
// the kill-on-close Job prevents a suspended child from surviving restart.
runContext, cancel := context.WithCancel(context.Background()) runContext, cancel := context.WithCancel(context.Background())
process, err := executor.Supervisor.Start(runContext, supervisor.StartSpec{IssueUUID: issue, CommandRevision: revision, Execution: proto.Clone(spec).(*rvboxv1.ExecutionSpec), ScriptBody: scriptBody, WorkingDirectory: workingDirectory, Environment: cloneEnvironment(spec.GetEnvOverrides()), ExecutionProfiles: executionProfileNames(spec.GetExecutionProfiles())}) process, err := executor.Supervisor.Start(runContext, supervisor.StartSpec{IssueUUID: issue, CommandRevision: revision, Execution: proto.Clone(spec).(*rvboxv1.ExecutionSpec), ScriptBody: scriptBody, WorkingDirectory: workingDirectory, Environment: cloneEnvironment(spec.GetEnvOverrides()), ExecutionProfiles: executionProfileNames(spec.GetExecutionProfiles())})
if err != nil { if err != nil {
@@ -134,6 +132,11 @@ func (executor *Executor) launch(ctx context.Context, issue domain.UUID, revisio
return executor.reject(ctx, issue, revision, err) return executor.reject(ctx, issue, revision, err)
} }
identity := process.Identity() identity := process.Identity()
if err := executor.Store.SetLaunchPhase(ctx, issue, domain.LaunchPhasePrepared, identity.Context, 0); err != nil {
_, _ = executor.Supervisor.Signal(context.Background(), process, supervisor.SignalKill)
cancel()
return err
}
if err := executor.Store.SetLaunchPhase(ctx, issue, domain.LaunchPhaseAuthorized, identity.Context, 0); err != nil { if err := executor.Store.SetLaunchPhase(ctx, issue, domain.LaunchPhaseAuthorized, identity.Context, 0); err != nil {
_, _ = executor.Supervisor.Signal(context.Background(), process, supervisor.SignalKill) _, _ = executor.Supervisor.Signal(context.Background(), process, supervisor.SignalKill)
cancel() cancel()