fix(server): omit redundant tombstone reconciliation discards
This commit is contained in:
1 parent
9e7c409ba7
commit
86a9cfdd72
9 files changed
+228
-3
No files matched your search
@@ -8,6 +8,37 @@ the repository and isolated fixtures. Do not restart/upgrade live services or
|
||||
replace the published installer for this feature without a later explicit
|
||||
instruction lifting that hold. See [the design](docs/transport-chunking.md).
|
||||
|
||||
## Legacy Windows client upgrade remains recommended
|
||||
|
||||
On 2026-11-16 a legacy client entered a persistent reconnect loop because the
|
||||
server echoed every already-compacted tombstone as a terminal-discard action.
|
||||
The redundant UUID list exceeded that client's 32 KiB WebSocket receive limit.
|
||||
The server correction omits those no-op actions only after the usual immutable
|
||||
hash/revision checks and reconciliation decision. Retained terminal commands
|
||||
still receive discard authorization, and contradictory non-terminal server
|
||||
state is still interrupted and incidented. Tombstones and history are preserved.
|
||||
|
||||
The isolated v16 hotfix excludes the held auto-chunking implementation. The
|
||||
new regression reproduces the original error using TLS, no subprotocol, a real
|
||||
32 KiB reader and 1,100 tombstones, then verifies repeat reconciliation after the
|
||||
fix. Store tests cover missing/terminal server rows, hash mismatch, and a
|
||||
tombstone contradicting running server state. Large genuine action lists,
|
||||
inline commands and stdin can still exceed the legacy reader; upgrade old
|
||||
Windows clients to the verified non-chunking installer. This optimization does
|
||||
not change the remaining 1 MiB logical snapshot limit or add pagination.
|
||||
|
||||
Recovery on 2026-11-16 was verified live: server version
|
||||
`0.1.0-gui-manual.16-tombstone.1`, based on `474afb3` plus only the store
|
||||
correction; no `internal/agentwire` package is present in that build source.
|
||||
The active fixture's Compose override pins the binary under
|
||||
`.test-runs/workstation-disconnect-20261116/`; treat it as a live deployment
|
||||
artifact, not disposable diagnostics. That directory also holds build
|
||||
provenance, the preserved pre-upgrade data/config and the guarded recovery script.
|
||||
Do not delete it while mounted. The existing published v16 installer is
|
||||
unchanged; its executable was checksum-verified on the user's desktop for
|
||||
manual upgrade from v11. No Windows service restart or command reissue was
|
||||
needed for server recovery.
|
||||
|
||||
## Reconciliation must restore a lost command acceptance
|
||||
|
||||
A reconnect can leave the server at `COMMAND_DISPATCHED` while the client has
|
||||
|
||||
Reference in new issue
Block a user