fix(windows): launch commands on the interactive desktop

This commit is contained in:
cabbage committed 2026-10-27 18:35:29 +00:00
1 parent 30e7bb8545
commit 8d28925e44
20 files changed
+1036 -28

No files matched your search

+65
View File
@@ -0,0 +1,65 @@
# Pending issues
## RVBox Windows commands do not reliably show GUI prompts
When a GUI uninstaller is launched through `rvc run --shell cmd`, its dialog may
not appear on the user's desktop. This was observed with IDA Freeware 7.0 and
HandBrake 1.6.1: their registered uninstallers ran through RVBox without a
visible confirmation dialog, and the apps remained installed after the
non-elevated attempts.
The command status selected the affected desktop's active user in session 1, with the
matching user SID. That rules out a simple Session 0 selection error, but does
not establish that the process shares Explorer's visible desktop. The Windows
launcher in the affected build started the shell with `STARTF_USESHOWWINDOW`
and `SW_HIDE`, then `CREATE_NEW_CONSOLE`, with `STARTUPINFO.lpDesktop` unset.
That hid the shell and did not explicitly select the user's visible desktop.
Microsoft's [STARTUPINFO documentation](https://learn.microsoft.com/en-us/windows/win32/api/processthreadsapi/ns-processthreadsapi-startupinfoa)
describes these startup fields as controlling the process's window station,
desktop, and initial window appearance; [ShowWindow](https://learn.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-showwindow)
uses the supplied startup state for an application's first window.
The repository's [GUI test guidance](docs/testing.md:249) explicitly says that
matching session IDs alone do not prove a process shares Explorer's window
station and desktop. Together, the hidden startup state and inherited desktop
are the strongest code-based explanation for the missing dialogs. No screenshot
or direct window-station inspection was available to confirm which condition
prevented these specific uninstaller windows from appearing.
The RVBox troubleshooting guide also says GUI work needs the intended
interactive session and desktop, and that token/session data alone is
insufficient ([troubleshooting.md](skills/rvbox/references/troubleshooting.md:57)).
Treat a successful command lifecycle as evidence that the launched process
exited, not that an uninstall completed. Verify the app's executable and
uninstall registration afterward.
### Implemented correction; native acceptance pending
The corrected launcher explicitly selects `winsta0\default` for active-user,
active-user-elevated, and active-system, including the command shell and signal
helper. The authenticated launcher reports its observed desktop and verifies
existing GUI access under the selected token before user code is prepared.
Session 0 contexts retain their noninteractive desktop. No desktop ACLs or
user-global terminal preferences are changed.
Shells now use `CREATE_NO_WINDOW` with `SW_SHOWNORMAL`, keeping console
suppression independent of GUI startup appearance. Existing output pipes,
suspended launch/authorization, Job containment, and TERM helper remain in use.
Console-event delivery needs native acceptance on this headless-console route.
Portable policy tests and Windows compilation cover the new path. Native tests
exercise actual desktop access, real GUI creation through the launcher, and
CTRL_BREAK observed by a controlled root PowerShell handler. The native harness
stages/checksums the self-contained GUI probe and checks visible-window evidence
for active-user, active-user-elevated, and active-system. These tests have not
been executed while Helium is offline; compilation is not a native pass.
Keep this issue open until the actual Windows desktop probe and the affected
uninstallers have been retested. The earlier `SW_HIDE` on the shell was a
plausible contributor, not proof that every GUI descendant inherited it.
Validate a real window and the application's final effect, including elevated
requirements, rather than inferring success from session/SID or process exit.
See [the advanced GUI guide](skills/rvbox/references/windows-gui.md) for `/wait`,
the diagnostic script, locked/background windows, Job lifetime and shell-policy
limits. Vendor unattended flags remain an optional workflow, not proof of a
working interactive launch path.