From 9e7c409ba7de252f0a9571cb06189c92a880a68e Mon Sep 17 00:00:00 2001 From: cabbage Date: Mon, 9 Nov 2026 09:02:40 +0000 Subject: [PATCH] docs: record lost acceptance reconnect recovery --- PENDING-ISSUES.md | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/PENDING-ISSUES.md b/PENDING-ISSUES.md index 3b64c25..388a0c6 100644 --- a/PENDING-ISSUES.md +++ b/PENDING-ISSUES.md @@ -8,6 +8,31 @@ the repository and isolated fixtures. Do not restart/upgrade live services or replace the published installer for this feature without a later explicit instruction lifting that hold. See [the design](docs/transport-chunking.md). +## Reconciliation must restore a lost command acceptance + +A reconnect can leave the server at `COMMAND_DISPATCHED` while the client has +durably accepted/executed the command. Current `ReconcileResumeDelivery` only +retargets its session generation. Replayed script-status events can commit, but +the next running event fails with `illegal command lifecycle transition +COMMAND_DISPATCHED -> COMMAND_RUNNING`, repeatedly closing the whole session. + +Temporary recovery was verified on 2026-11-09 without changing the v16 binary: +stop the server, preserve its complete data/config, rehearse on an independent +copy, and use `Store.RecordCommandAcceptance` for the single affected command. +The recovery checked its owner, UUID, revision, generation, event sequence, and +durable completed-script receipt. It restored only acceptance; client replay +then supplied the actual running/terminal events and existing cancellation +result. No command was reissued and no event sequence or terminal result was +invented. This is an incident-specific repair, not a general SQL-edit recipe. + +The permanent correction needs an atomic reconciliation update based on the +matching client snapshot: restore a missing acceptance only for compatible +client lifecycle, immutable hash, revision, and owning session. Keep ordinary +lifecycle transition checks strict. Add lost-acceptance/reconnect coverage with +already-persisted script status, running/terminal event replay, fencing/hash/ +revision rejection, and proof of no duplicate execution. This correction is +separate from the held auto-chunking feature and has not been deployed. + ## RVBox Windows commands do not reliably show GUI prompts When a GUI uninstaller is launched through `rvc run --shell cmd`, its dialog may