feat(windows): simplify tray controls and allow installer-user config edits
This commit is contained in:
1 parent
d59b2d5463
commit
ae5e979761
18 files changed
+611
-88
No files matched your search
@@ -0,0 +1,65 @@
|
||||
package windowstray
|
||||
|
||||
import (
|
||||
"errors"
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
"github.com/rvbox/rvbox/internal/client/windowsservice"
|
||||
)
|
||||
|
||||
func TestTrayStatusUsesSCMAndConnection_HP_WINTRAY_05(t *testing.T) {
|
||||
for _, tc := range []struct {
|
||||
name string
|
||||
service windowsservice.Status
|
||||
err error
|
||||
connection string
|
||||
label string
|
||||
start, stop, auto, known bool
|
||||
}{
|
||||
{"connected", windowsservice.Status{Installed: true, State: windowsservice.StateRunning, Startup: windowsservice.StartupAutomatic}, nil, "running", "Status: running", false, true, true, true},
|
||||
{"disconnected", windowsservice.Status{Installed: true, State: windowsservice.StateRunning, Startup: windowsservice.StartupManual}, nil, "disconnected", "Status: disconnected", false, true, false, true},
|
||||
{"unresponsive pipe", windowsservice.Status{Installed: true, State: windowsservice.StateRunning, Startup: windowsservice.StartupAutomatic}, nil, "", "Status: disconnected", false, true, true, true},
|
||||
{"stopped ignores stale connection", windowsservice.Status{Installed: true, State: windowsservice.StateStopped, Startup: windowsservice.StartupAutomatic}, nil, "running", "Status: stopped", true, false, true, true},
|
||||
{"starting", windowsservice.Status{Installed: true, State: windowsservice.StateStartPending, Startup: windowsservice.StartupManual}, nil, "", "Status: starting", false, false, false, true},
|
||||
{"stopping", windowsservice.Status{Installed: true, State: windowsservice.StateStopPending, Startup: windowsservice.StartupAutomatic}, nil, "running", "Status: stopping", false, false, true, true},
|
||||
{"not installed", windowsservice.Status{State: windowsservice.StateStopped}, nil, "", "Status: stopped", false, false, false, false},
|
||||
{"access denied", windowsservice.Status{}, errors.New("access denied"), "running", "Status: unavailable", false, false, false, false},
|
||||
{"unknown startup", windowsservice.Status{Installed: true, State: windowsservice.StateRunning}, nil, "running", "Status: running", false, true, false, false},
|
||||
} {
|
||||
t.Run(tc.name, func(t *testing.T) {
|
||||
got := menuStatus(tc.service, tc.err, tc.connection)
|
||||
want := MenuStatus{Label: tc.label, CanStart: tc.start, CanStop: tc.stop, AutoStart: tc.auto, StartupKnown: tc.known}
|
||||
if got != want {
|
||||
t.Fatalf("status=%#v, want %#v", got, want)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestTrayMenuHasBannerAndSingleAutoToggle_HP_WINTRAY_06(t *testing.T) {
|
||||
for _, automatic := range []bool{false, true} {
|
||||
items := trayMenu(MenuStatus{Label: "Status: running", AutoStart: automatic, StartupKnown: true, CanStop: true})
|
||||
if items[0].Action != 0 || !items[0].Disabled || items[0].Label != "Status: running" {
|
||||
t.Fatalf("status is clickable: %#v", items[0])
|
||||
}
|
||||
count := 0
|
||||
for _, item := range items {
|
||||
if item.Action == ActionStatus || item.Action == ActionRestartService || item.Action == ActionSetManual || strings.Contains(item.Label, "automatically") || strings.Contains(item.Label, "manually") {
|
||||
t.Fatalf("obsolete menu item: %#v", item)
|
||||
}
|
||||
if item.Label == "Auto start" {
|
||||
count++
|
||||
if item.Checked != automatic || item.Disabled {
|
||||
t.Fatalf("bad toggle: %#v", item)
|
||||
}
|
||||
}
|
||||
}
|
||||
if count != 1 {
|
||||
t.Fatalf("auto start count=%d", count)
|
||||
}
|
||||
if automaticAction(automatic) == ActionSetAutomatic && automatic || automaticAction(automatic) == ActionSetManual && !automatic {
|
||||
t.Fatal("toggle does not invert confirmed SCM state")
|
||||
}
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user