fix(windows): make installer upgrades version aware

This commit is contained in:
cabbage committed 2026-10-27 15:17:52 +00:00
1 parent 6906ed52f2
commit ee7844cb40
14 files changed
+824 -51

No files matched your search

+32
View File
@@ -263,6 +263,38 @@ visible/responsive when its service is absent or its IPC peer stalls. Windows
may put a new application icon under its hidden-icons arrow; do not rewrite the
user's global notification-area preferences to force pinning.
Installer lifecycle regressions `HP-WINCLI-10/11` and `BH-WINCLI-03/04` run on
Linux: fresh/upgrade ordering, healthy same-version no-op, stopped/paused/pending
SCM states, missing tray, cancellation/inspection failure without subsequent
mutations, and version-string/hash identity. Native `HP-WINCLI-12..15` cover
SCM path retention, packaged PE version strings, concurrent installer exclusion,
and real Win32 executable replacement while retaining adjacent config contents.
Build `./cmd/rvbox` with `GOOS=windows GOARCH=amd64 go test -c` as a distinct
console test executable. To exercise the actual release resource, set
`RVBOX_NATIVE_RELEASE_EXE` to the package path and
`RVBOX_NATIVE_RELEASE_VERSION` to its full release label before running it;
otherwise that one case explicitly skips.
On an interactive physical machine or disposable Windows fixture, test:
1. Upgrade an older installed package. Confirm UAC, exactly one service and tray,
the new executable version, unchanged custom config/client identity/history
and Automatic/Manual setting, and the minimal success dialog.
2. Run that same package again with both components running. Require no UAC or
dialog and unchanged service/tray PIDs. It must not reinstall or rewrite files.
3. Exit only the tray and relaunch setup. Require a new tray with unchanged
service PID and no UAC. Stop the service and repeat with/without the tray;
require service start (UAC when necessary) and only a missing tray to start.
4. Cancel the service-start/upgrade UAC prompt. Require no replacement/new tray.
Launch two setups during UAC; the second must exit quietly. On a disposable
fixture, reject invalid existing TOML before stopping the working service and
exercise replacement/startup failure plus best-effort prior-binary recovery.
These native lifecycle checks are pending for the new version-aware installer
while Helium is offline; passing portable tests and Windows cross-compilation
does not prove them. Retain the previous installer for recovery during physical
testing, and collect `service-startup.log` if service start fails.
Regression `BH-WINTRAY-06` checks successful HRESULTs (`S_OK` and `S_FALSE`)
versus actual failures. On the Windows 10 fixture, the installed, responsive
tray returned `S_FALSE` (`1`) with valid icon coordinates; a readiness check