cabbage/codex-telegram-bot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use default Codex approval reviewer

Browse Source 
Stop forcing approvalsReviewer=user on thread and turn start so reviewer routing follows Codex app-server defaults, matching CLI behavior.
This commit is contained in:
Codex
2026-05-28 10:23:59 +00:00
parent 34e909f9cf
commit 44384a90c7
2 changed files with 9 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
internal/codexapp/client.go
View File

@@ -248,11 +248,10 @@ func (c *Client) StartThread(ctx context.Context, cwd, model, sandbox string) (T
return Thread{}, err return Thread{}, err
} }
params := map[string]any{ params := map[string]any{
"cwd": cwd, "cwd": cwd,
"approvalPolicy": "on-request", "approvalPolicy": "on-request",
"approvalsReviewer": "user", "sandbox": threadSandbox(sandbox),
"sandbox": threadSandbox(sandbox), "serviceName": "codex_telegram_bot",
"serviceName": "codex_telegram_bot",
} }
if model != "" { if model != "" {
params["model"] = model params["model"] = model
@@ -336,10 +335,9 @@ func (c *Client) StartTurn(ctx context.Context, threadID, cwd, model, reasoningE
return Turn{}, err return Turn{}, err
} }
params := map[string]any{ params := map[string]any{
"threadId": threadID, "threadId": threadID,
"input": input, "input": input,
"approvalPolicy": "on-request", "approvalPolicy": "on-request",
"approvalsReviewer": "user",
} }
if strings.TrimSpace(cwd) != "" { if strings.TrimSpace(cwd) != "" {
params["cwd"] = cwd params["cwd"] = cwd

4
internal/codexapp/client_test.go
View File

@@ -78,7 +78,7 @@ func TestClientWebSocketUnixJSONRPC(t *testing.T) {
return return
} }
startParams := start["params"].(map[string]any) startParams := start["params"].(map[string]any)
if startParams["approvalsReviewer"] != "user" || startParams["approvalPolicy"] != "on-request" { if _, ok := startParams["approvalsReviewer"]; ok || startParams["approvalPolicy"] != "on-request" {
payload, _ := json.Marshal(startParams) payload, _ := json.Marshal(startParams)
serverDone <- unexpectedMessage("thread/start approval params", string(payload)) serverDone <- unexpectedMessage("thread/start approval params", string(payload))
return return
@@ -104,7 +104,7 @@ func TestClientWebSocketUnixJSONRPC(t *testing.T) {
return return
} }
turnParams := turnStart["params"].(map[string]any) turnParams := turnStart["params"].(map[string]any)
if turnParams["approvalsReviewer"] != "user" || turnParams["approvalPolicy"] != "on-request" { if _, ok := turnParams["approvalsReviewer"]; ok || turnParams["approvalPolicy"] != "on-request" {
payload, _ := json.Marshal(turnParams) payload, _ := json.Marshal(turnParams)
serverDone <- unexpectedMessage("turn/start approval params", string(payload)) serverDone <- unexpectedMessage("turn/start approval params", string(payload))
return return